492 Commits

Author SHA1 Message Date
Znote
acaccc5960 Update Readme 2019-11-11 06:57:13 +01:00
Znote
14bec26444 Bump required PHP version to 5.6 2019-11-11 06:56:59 +01:00
Znote
da58e68d83 Fix typo in Znote AAC schema 2019-11-11 06:49:04 +01:00
Znote
e96cf7f2b7 Fix #363 Guild leaders can no longer leave their guild
Unless they decide to properly disband it first.
2019-11-11 06:16:44 +01:00
Znote
de9eb60638 Fix #280 Importing Znote AAC schema fixes
It will now import old accounts and players to be compatible with Znote AAC
It will also remove duplicates if it finds any
2019-11-11 06:04:55 +01:00
Znote
45c0ec109d Fix #305 SQL Error while creating/updating new forum boards. 2019-11-11 04:25:43 +01:00
Znote
6fd5aa5409 Implemented EQ + skills + full outfit display in character profile 2019-11-10 09:43:00 +01:00
Znote
b65c860b66 Fix #369 - Outfit offer type (5) supports 2 outfit ids. 2019-11-09 22:04:16 +01:00
Znote
be8b882166 Possibility to reward users with shop points if they verify their email
Also generates a new activation key after they have verified their email in-case they change their email and guess the activation link for their fake email.
Also removes the given points until they verify their email again if they change their email.
2019-10-23 21:06:24 +02:00
Znote
d8f22f9c33 Initialize active_email in init.php.
Forgot to include it in the previous update.
2019-10-22 03:13:32 +02:00
Znote
00a97d43e4 Allow users to verify their email in myaccount.php
Even if they arent forced to verify email during registration.
If they change their email in the settings later, the verification is lost.
Todo: Add a reward for first-time verification.
2019-10-22 02:05:14 +02:00
Znote
44dd48b17e Fix "Cannot redeclare PHPMailerAutoload()"
When sending multiple emails in bulk.
2019-10-19 03:24:57 +02:00
Znote
734f5c7969 Dont allow _ symbol when creating character name. 2019-10-16 22:45:48 +02:00
Stefan A. Brannfjell
27d7ce44eb
house.php: Rebase house declaration with #359
Somehow managed to overwrite it with an old copy.
2019-09-28 09:32:01 +02:00
Znote
56050fcb29 TFS 1.0: Direct house purchase with shop points
Allow players to directly purchase houses using shop points.
https://otland.net/threads/znote-aac-shop-house-offers.266507/
2019-09-28 09:25:47 +02:00
Znote
8a8baba9fc Suppressed uneccesary error in change character name. myaccount.php
When you dont have ticket to do change your name, a sync error appeared, even though its not a sync error.
2019-09-22 23:44:26 +02:00
Znote
7f1a4af7d2 Globalevent shop: Confirm player has enough available slots 2019-09-15 22:05:32 +02:00
Znote
e69021e01c Lua TFS 1.x: Globalevent shop system. 2019-09-14 21:06:33 +02:00
Znote
c0f891b2d7 Process all orders at once in shop talkaction script 2019-09-09 02:16:37 +02:00
divinity76
c5323dbc78 admin.php protection against XSS and CSRF (#367)
admin.php protection against XSS and CSRF
see https://github.com/Znote/ZnoteAAC/issues/361 for more info
2019-08-27 00:25:51 +02:00
divinity76
4c3c2fab1f better $postdata encoding (#366)
idk what stripslashes() was doing in there, but it was definitely a bug (there's no way the slashes in there, if any, had no purpose and could just be discarded.. right?)

in addition, post data with keys containing special characters (if any) was incorrectly encoded. a correct encoding loop goes like:

foreach ($_POST as $key => $value) {
	$req.="&".urlencode($key)."=".urlencode($value);
}
but the original code was only encoding the value, not the key... but even better than a custom encoding loop is to just use http_build_query(), which does the entire encoding loop for us :) so that's what i changed it to.
2019-08-26 02:12:53 +02:00
divinity76
3c15ead4cf "no content OK" is HTTP 204, not HTTP 200. (#365)
read section 6.3.5 of https://tools.ietf.org/html/rfc7231#section-6.3.5 for proof.
2019-08-26 02:11:18 +02:00
divinity76
01c5da322a html-encode dynamic values in buypoints.php (#364)
* add html encoding function

* html-encode dynamic values

important if the values contain special characters like '&<>"

(for example if $config['site_title'] is `AT&T` or `<AWESOMESERVER>`, the old code would generate invalid html, but this updated code will generate valid html.)
2019-08-26 02:11:02 +02:00
Evil Puncker
53dbc9fdd7 Updated login to work with newer 12 client (#362)
Added missing field, missing only world pvp type
2019-08-07 15:58:34 +02:00
gregorecruzeiro
8404f8e171 Update house.php (#359)
Fixed undefined index id when accessing house.php directly.
2019-04-25 17:29:39 +02:00
divinity76
d9cd81508b patch XSS vulnerability (#358)
the powergamers page was vulnerable to XSS/javascript injection, this should fix it.

XSS screenshot: https://i.imgur.com/4rJuWqY.png
XSS POC:

<form action="https://<censored>/powergamers.php" method="POST">
<input type="hidden" name="days[]" value="3" />
<input type="hidden" name="days[]" value="1&lt;script&gt;alert(&quot;XSS running!&quot;);&lt;/script&gt;" />
<input type="submit" value="click here to start xss" />
</form>
2019-04-19 21:23:57 +02:00
slawkens
c0fe9e5d85 Enable local SSL certificate verification (#356)
This fixes points being not delivered on same systems.

Also set the CURLOPT_SSLVERSION as stated here https://www.php.net/manual/de/function.curl-setopt.php#118536
2019-04-13 01:06:46 +02:00
Stefan A. Brannfjell
f5bbc78101
ipn.php: Verify peer and host in SSL
Security issue reported by @slawkens 

All wifi traffic is broadcasted - this means that any nearby sniffing devices can read your traffic. If you're connecting to a page through HTTP over public/unencrypted wifi you can assume that whatever information you are sending and receiving is public - all it takes is an attacker nearby with an antenna to read all that in plaintext. To perform a true MITM by having traffic flow through them, attackers can use technologies like WiFi pineapples or aircrack-ng to force users to connect to their wifi network.

Connecting over cable internet is much harder to intercept/mitm because you're not broadcasting your traffic for the whole neighborhood. In order to compromise this network an attacker will have to gain access to it somehow - either through physical access to a network port, malware installed on a host machine or router, etc. When an attacker has access to a network they then have to exploit that access through attacks such as ARP poisoning or HSRP spoofing. These attacks just MITM traffic - anyone on the network can still sniff (read, but not change) traffic, but keep in mind HTTPS traffic is still encrypted and can't be read.

https://security.stackexchange.com/questions/153148/how-easy-it-is-to-actually-perform-mitm-attack-these-days
2019-04-13 00:34:11 +02:00
Znote
ce3fcf3b51 Fixed OTHIRE forum accountAccess check 2019-04-12 02:32:07 +02:00
Znote
15689d3aed Fixed OTHIRE account registration bug 2019-04-04 00:53:28 +02:00
Znote
e64032e630 Fixed OTHIRE account registration bug 2019-04-04 00:49:32 +02:00
Znote
a76e468645 Retrieve descriptive vocation name if id is not configured. 2019-04-03 22:46:24 +02:00
Znote
9f95fa4bb8 Fix #353 2019-03-22 19:35:12 +01:00
Stefan A. Brannfjell
6fee46767b
Fix #351 - syntax error in register.php 2019-03-19 11:43:09 +01:00
Rodrigo Paixão
a3f2cce4aa -- Fix Create Account (Compatibility OTHire) (#350) 2019-03-18 22:54:13 +01:00
gregorecruzeiro
ca989223bc Fix admin_shop.php (#348)
Notice: Undefined index: points in admin_shop.php on line 61
2019-03-18 02:01:30 +01:00
Znote
7eebbde59e Fix #345 - Character Auction storage account
When storage_account_id is not configured in config.php and people want to try the character auction system
Give them an error message instead of a query crash. Telling them to edit config.php properly.
2019-03-18 01:53:38 +01:00
Znote
63357290a0 Fix #346 Uneccesary OTHire engine logic separation
There is no need to create a separate configs for OTHIRE when establishing an SQL connection,
and is confusing for new users who are configurating their webserver.
2019-03-17 19:43:41 +01:00
Znote
44839d9cdb Fix #303 SQL error when joining a guild when your already in another guild 2019-03-17 19:07:45 +01:00
Znote
32bbecd266 Fix ##295 Rounding discount in buypoints 2019-03-17 14:53:11 +01:00
Znote
effe5d2b8e Adding page specific class to layout body 2019-03-17 01:41:03 +01:00
Znote
58e6300cf7 Fix #287 characterprofile table design 2019-03-17 01:38:29 +01:00
gregorecruzeiro
e8a57cbac3 Update toponline.php site_title and type (#347)
* Update toponline.php site_title and type

Parse error: syntax error, unexpected 'site_title' (T_STRING), expecting ',' or ';' in C:\xampp\htdocs\znote\toponline.php on line 40
Notice: Undefined index: type in C:\xampp\htdocs\znote\toponline.php on line 10
2019-03-14 09:18:50 +01:00
Rodrigo Paixão
bbd0455463 Admin Page - Compatibility OTHire (#342)
-- Fix for Admin Page in OTHire
2019-03-12 15:35:02 +01:00
Znote
9c80585ef9 Character Auction System 2019-03-10 18:53:24 +01:00
Znote
deebe044b1 CSS fixes for outfit image in highscore and character auction 2019-03-10 13:01:06 +01:00
Znote
fbcaa6e7e4 #More visually compatible house filtering 2019-03-10 11:58:56 +01:00
Kristoffer Eklund
00828a9f70 update PHPMailer info (#341) 2019-03-08 22:16:41 +01:00
Kristoffer Eklund
5dbee1cd46 PHPMailer 6.0 support (#340)
* PHPMailer 6.0 support

* dont require the PHPMailer files until sendMail is called

* cs fixes
2019-03-08 21:20:38 +01:00
Znote
e13bda4df1 New credits page. 2019-03-05 19:19:31 +01:00