reorganize some stuff

modules/addon_console/console.lua

@@ -10,7 +10,7 @@ local LabelHeight = 16
 -- private variables
 local consoleWidget
 local logLocked = false
-local commandEnv = createEnvironment()
+local commandEnv = newenv()
 local commandLineEdit
 local consoleBuffer
 local commandHistory = { }

modules/addon_console/console.otmod

@@ -12,7 +12,6 @@ Module
     require 'console'
     require 'commands'
     Console.init()
-    return true
 
   onUnload: |
     Console.terminate()

modules/addon_playground/playground.otmod

@@ -3,5 +3,4 @@ Module
   autoLoad: true
   onLoad: |
     require 'playground'
-    return true
 

modules/client/client.lua

@@ -1,8 +1,9 @@
-Client = { }
+Client = {}
 
 -- TODO: load and save configurations
 function Client.init()
   g_window.show()
+  g_window.setMinimumSize({ width = 550, height = 450 })
 
   -- initialize in fullscreen mode on mobile devices
   if g_window.getPlatformType() == "X11-EGL" then
@@ -19,8 +20,11 @@ function Client.init()
   end
 
   g_window.setTitle('OTClient')
-  g_window.setIcon('clienticon.png')
-  return true
+  g_window.setIcon(resolvepath('clienticon.png'))
+
+  if not g_sprites.isLoaded() or not g_thingsType.isLoaded() then
+    fatal("spr and dat files are not loaded, did you loaded them?")
+  end
 end
 
 function Client.terminate()

modules/client/client.otmod

@@ -16,7 +16,7 @@ Module
 
   onLoad: |
     require 'client'
-    return Client.init()
+    Client.init()
 
   onUnload: |
     Client.terminate()

modules/client_about/about.otmod

@@ -6,5 +6,3 @@ Module
 
   onLoad: |
     require 'about'
-    return true
-

modules/client_background/background.otmod

@@ -7,7 +7,6 @@ Module
   onLoad: |
     require 'background'
     Background.create()
-    return true
 
   onUnload:
     Background.destroy()

modules/client_entergame/entergame.otmod

@@ -8,7 +8,6 @@ Module
     require 'entergame'
     require 'characterlist'
     EnterGame.create()
-    return true
 
   onUnload:
     EnterGame.destroy()

modules/client_options/options.otmod

@@ -6,5 +6,3 @@ Module
 
   onLoad: |
     require 'options'
-    return true
-

modules/client_topmenu/topmenu.otmod

@@ -7,7 +7,6 @@ Module
   onLoad: |
     require 'topmenu'
     TopMenu.create()
-    return true
 
   onUnload: |
     TopMenu.destroy()

modules/core/core.otmod

@@ -10,7 +10,7 @@ Module
 
   // NOTE: order does matter
   dependencies:
-    - core_scripts
+    - core_lib
     - core_fonts
     - core_styles
     - core_widgets

modules/core_fonts/core_fonts.otmod

@@ -4,10 +4,9 @@ Module
   author: OTClient team
   website: https://github.com/edubart/otclient
   onLoad: |
-    importFont('verdana-11px-antialised')
-    importFont('verdana-11px-monochrome')
-    importFont('verdana-11px-rounded')
-    importFont('terminus-14px-bold')
-    setDefaultFont('verdana-11px-antialised')
-    return true
+    importFont 'verdana-11px-antialised'
+    importFont 'verdana-11px-monochrome'
+    importFont 'verdana-11px-rounded'
+    importFont 'terminus-14px-bold'
+    setDefaultFont 'verdana-11px-antialised'
 

modules/core_lib/core_lib.otmod

@@ -1,5 +1,5 @@
 Module
-  name: core_scripts
+  name: core_lib
   description: Contains core lua classes, functions and constants used by other modules
   author: OTClient team
   website: https://github.com/edubart/otclient
@@ -7,14 +7,13 @@ Module
   onLoad: |
     require 'ext/table'
     require 'ext/string'
-    require 'util/point'
-    require 'util/size'
-    require 'util/color'
-    require 'util/rect'
+    require 'math/point'
+    require 'math/size'
+    require 'math/color'
+    require 'math/rect'
     require 'const'
     require 'util'
+    require 'globals'
     require 'dispatcher'
     require 'widget'
-    require 'ui'
     require 'effects'
-    return true

modules/core_lib/globals.lua

@@ -1,9 +1,15 @@
--- globals
 rootWidget = g_ui.getRootWidget()
 
--- public functions
 function importStyle(otui)
-  g_ui.importStyle(resolveFileFullPath(otui, 2))
+  g_ui.importStyle(resolvepath(otui, 2))
+end
+
+function importFont(otfont)
+  g_fonts.importFont(resolvepath(otfont, 2))
+end
+
+function setDefaultFont(font)
+  g_fonts.setDefaultFont(font)
 end
 
 function displayUI(arg1, options)
@@ -14,7 +20,7 @@ function displayUI(arg1, options)
 
   -- display otui files
   if type(arg1) == 'string' then
-    local otuiFilePath = resolveFileFullPath(arg1, 2)
+    local otuiFilePath = resolvepath(arg1, 2)
     widget = g_ui.loadUI(otuiFilePath, parent)
   -- display already loaded widgets
   else

modules/core_lib/util.lua

@@ -26,13 +26,26 @@ function connect(object, signalsAndSlots, pushFront)
   end
 end
 
-function createEnvironment()
+function extends(base)
+  local derived = {}
+  function derived.internalCreate()
+    local instance = base.create()
+    for k,v in pairs(derived) do
+      instance[k] = v
+    end
+    return instance
+  end
+  derived.create = derived.internalCreate
+  return derived
+end
+
+function newenv()
   local env = { }
   setmetatable(env, { __index = _G} )
   return env
 end
 
-function getCallingScriptSourcePath(depth)
+function getfsrcpath(depth)
   depth = depth or 2
   local info = debug.getinfo(1+depth, "Sn")
   local path
@@ -47,25 +60,11 @@ function getCallingScriptSourcePath(depth)
   return path
 end
 
-function resolveFileFullPath(filePath, depth)
+function resolvepath(filePath, depth)
   depth = depth or 1
   if filePath:sub(0, 1) ~= '/' then
-    return getCallingScriptSourcePath(depth+1) .. '/' .. filePath
+    return getfsrcpath(depth+1) .. '/' .. filePath
   else
     return filePath
   end
 end
-
-function extends(base)
-  local derived = {}
-  function derived.internalCreate()
-    local instance = base.create()
-    for k,v in pairs(derived) do
-      instance[k] = v
-    end
-    return instance
-  end
-  derived.create = derived.internalCreate
-  return derived
-end
-

modules/core_styles/core_styles.otmod

@@ -17,4 +17,3 @@ Module
     importStyle 'styles/creatures.otui'
     importStyle 'styles/popupmenus.otui'
     importStyle 'styles/comboboxes.otui'
-    return true

modules/core_widgets/core_widgets.otmod

@@ -10,5 +10,4 @@ Module
     require 'uibutton'
     require 'uilabel'
     require 'uicombobox'
-    require 'uipopupmenu'
-    return true
+    require 'uipopupmenu'

modules/core_widgets/uicheckbox.lua

@@ -0,0 +1,8 @@
+UICheckBox = extends(UIWidget)
+
+function UICheckBox.create()
+  local checkbox = UICheckBox.internalCreate()
+  checkbox:setFocusable(false)
+  checkbox:setAlign(AlignLeft)
+  return checkbox
+end

modules/game/game.otmod

@@ -16,4 +16,3 @@ Module
   onLoad: |
     require 'game'
     require 'thing'
-    return true

modules/game_chat/chat.otmod

@@ -5,6 +5,3 @@ Module
   website: https://github.com/edubart/otclient
   onLoad: |
     require 'chat'
-    return true
-
-

modules/game_healthbar/healthbar.otmod

@@ -5,6 +5,3 @@ Module
   website: https://github.com/edubart/otclient
   onLoad: |
     require 'healthbar'
-    return true
-
-

modules/game_inventory/inventory.otmod

@@ -5,6 +5,3 @@ Module
   website: https://github.com/edubart/otclient
   onLoad: |
     require 'inventory'
-    return true
-
-

modules/game_outfit/outfit.otmod

@@ -5,6 +5,3 @@ Module
   website: https://github.com/edubart/otclient
   onLoad: |
     require 'outfit'
-    return true
-
-

modules/game_skills/skills.otmod

@@ -5,4 +5,3 @@ Module
   website: https://github.com/edubart/otclient
   onLoad: |
     require 'skills'
-    return true

modules/game_textmessage/textmessage.otmod

@@ -5,5 +5,3 @@ Module
   website: https://github.com/edubart/otclient
   onLoad: |
     require 'textmessage'
-    return true
-

modules/game_viplist/viplist.otmod

@@ -5,6 +5,3 @@ Module
   website: https://github.com/edubart/otclient
   onLoad: |
     require 'viplist'
-    return true
-
-