Digitalstack/otclient
2
0
Fork 0
mirror of https://github.com/edubart/otclient.git synced 2025-12-26 17:57:11 +01:00
Code Issues Packages Projects Releases Wiki Activity

Fix memory leaks

Browse Source 
* Fix recursive reference memory leak in UIWidget
* Make Event/ScheduledEvent memory-leak safe
* Fix exit crashs by freeing graphics resources before destroying GL context
* Add many asserts to avoid any leak regression
This commit is contained in:
Eduardo Bart
2012-06-18 05:13:52 -03:00
parent f650b0e5bb
commit 1c7bbaea89
42 changed files with 326 additions and 81 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
src/framework/ui/uimanager.cpp
View File

@@ -50,6 +50,9 @@ void UIManager::terminate()
m_draggingWidget = nullptr;
m_hoveredWidget = nullptr;
m_pressedWidget = nullptr;
m_styles.clear();
m_destroyedWidgets.clear();
m_checkEvent = nullptr;
}
void UIManager::render(Fw::DrawPane drawPane)
@@ -266,22 +269,19 @@ void UIManager::onWidgetDestroy(const UIWidgetPtr& widget)
if(m_draggingWidget == widget)
updateDraggingWidget(nullptr);
#ifdef DEBUG
static UIWidgetList destroyedWidgets;
static ScheduledEventPtr checkEvent;
if(widget == m_rootWidget)
#ifndef DEBUG
if(widget == m_rootWidget || !m_rootWidget)
return;
destroyedWidgets.push_back(widget);
m_destroyedWidgets.push_back(widget);
if(checkEvent && !checkEvent->isExecuted())
if(m_checkEvent && !m_checkEvent->isExecuted())
return;
checkEvent = g_eventDispatcher.scheduleEvent([] {
m_checkEvent = g_eventDispatcher.scheduleEvent([] {
g_lua.collectGarbage();
UIWidgetList backupList = destroyedWidgets;
destroyedWidgets.clear();
UIWidgetList backupList = m_destroyedWidgets;
m_destroyedWidgets.clear();
g_eventDispatcher.scheduleEvent([backupList] {
g_lua.collectGarbage();
for(const UIWidgetPtr& widget : backupList) {