From eca896954cd5fc6dd07be3a558abca2a319e4af1 Mon Sep 17 00:00:00 2001 From: slawkens Date: Fri, 4 Aug 2023 15:47:32 +0200 Subject: [PATCH] Every setting needs to have default --- system/libs/Settings.php | 8 -------- system/settings.php | 4 ++++ 2 files changed, 4 insertions(+), 8 deletions(-) diff --git a/system/libs/Settings.php b/system/libs/Settings.php index b5fd260c..7bf61bc2 100644 --- a/system/libs/Settings.php +++ b/system/libs/Settings.php @@ -319,14 +319,6 @@ class Settings implements ArrayAccess echo ($setting['desc'] ?? ''); echo '
'; echo 'Default: '; - if (empty($setting['default'])) { - if ($setting['type'] === 'boolean' && $setting['default'] !== false) { - $setting['default'] = true; - } - else { - $setting['default'] = ''; - } - } if ($setting['type'] === 'boolean') { echo ($setting['default'] ? 'Yes' : 'No'); diff --git a/system/settings.php b/system/settings.php index 60a8fbb7..183425af 100644 --- a/system/settings.php +++ b/system/settings.php @@ -294,6 +294,7 @@ return [ 'database_user' => [ 'name' => 'Database User', 'type' => 'text', + 'default' => '', 'show_if' => [ 'database_overwrite', '=', 'true' ], @@ -302,6 +303,7 @@ return [ 'database_password' => [ 'name' => 'Database Password', 'type' => 'text', + 'default' => '', 'show_if' => [ 'database_overwrite', '=', 'true' ], @@ -310,6 +312,7 @@ return [ 'database_name' => [ 'name' => 'Database Name', 'type' => 'text', + 'default' => '', 'show_if' => [ 'database_overwrite', '=', 'true' ], @@ -319,6 +322,7 @@ return [ 'name' => 'Database Socket', 'desc' => 'Set if you want to connect to database through socket (example: /var/run/mysqld/mysqld.sock)', 'type' => 'text', + 'default' => '', 'show_if' => [ 'database_overwrite', '=', 'true' ],