Forum: nothing important, just formatting

system/pages/forum/admin.php

@@ -14,28 +14,32 @@ $canEdit = Forum::isModerator();
 if($canEdit) {
 	$groups = new OTS_Groups_List();
 
-	if(!empty($action))
+	if(!empty($action)) {
-	{
 		if($action == 'delete_board' || $action == 'edit_board' || $action == 'hide_board' || $action == 'moveup_board' || $action == 'movedown_board')
 			$id = $_REQUEST['id'];
 
-		if(isset($_REQUEST['access']))
+		if(isset($_REQUEST['access'])) {
 			$access = $_REQUEST['access'];
+		}
 
-		if(isset($_REQUEST['guild']))
+		if(isset($_REQUEST['guild'])) {
 			$guild = $_REQUEST['guild'];
+		}
 
-		if(isset($_REQUEST['name']))
+		if(isset($_REQUEST['name'])) {
 			$name = $_REQUEST['name'];
+		}
 
-		if(isset($_REQUEST['description']))
+		if(isset($_REQUEST['description'])) {
 			$description = stripslashes($_REQUEST['description']);
+		}
 
-		$errors = array();
+		$errors = [];
 
 		if($action == 'add_board') {
-			if(Forum::add_board($name, $description, $access, $guild, $errors))
+			if(Forum::add_board($name, $description, $access, $guild, $errors)) {
 				$action = $name = $description = '';
+			}
 		}
 		else if($action == 'delete_board') {
 			Forum::delete_board($id, $errors);

system/pages/forum/base.php

@@ -11,10 +11,8 @@
 defined('MYAAC') or die('Direct access not allowed!');
 $title = 'Forum';
 
-if(strtolower($config['forum']) != 'site')
+if(strtolower($config['forum']) != 'site') {
-{
+	if($config['forum'] != '') {
-	if($config['forum'] != '')
-	{
 		header('Location: ' . $config['forum']);
 		exit;
 	}
@@ -23,14 +21,14 @@ if(strtolower($config['forum']) != 'site')
 	return;
 }
 
-if(!$logged)
+if(!$logged) {
-	echo  'You are not logged in. <a href="?subtopic=accountmanagement&redirect=' . BASE_URL . urlencode('?subtopic=forum') . '">Log in</a> to post on the forum.<br /><br />';
+	echo 'You are not logged in. <a href="?subtopic=accountmanagement&redirect=' . BASE_URL . urlencode('?subtopic=forum') . '">Log in</a> to post on the forum.<br /><br />';
+}
 
 require_once LIBS . 'forum.php';
 
 $sections = array();
-foreach(getForumBoards() as $section)
+foreach(getForumBoards() as $section) {
-{
 	$sections[$section['id']] = array(
 		'id' => $section['id'],
 		'name' => $section['name'],

system/pages/forum/edit_post.php

@@ -22,17 +22,15 @@ if(Forum::canPost($account_logged))
 	}
 
 	$thread = $db->query("SELECT `author_guid`, `author_aid`, `first_post`, `post_topic`, `post_date`, `post_text`, `post_smile`, `post_html`, `id`, `section` FROM `" . FORUM_TABLE_PREFIX . "forum` WHERE `id` = ".$post_id." LIMIT 1")->fetch();
-	if(isset($thread['id']))
+	if(isset($thread['id'])) {
-	{
 		$first_post = $db->query("SELECT `" . FORUM_TABLE_PREFIX . "forum`.`author_guid`, `" . FORUM_TABLE_PREFIX . "forum`.`author_aid`, `" . FORUM_TABLE_PREFIX . "forum`.`first_post`, `" . FORUM_TABLE_PREFIX . "forum`.`post_topic`, `" . FORUM_TABLE_PREFIX . "forum`.`post_text`, `" . FORUM_TABLE_PREFIX . "forum`.`post_smile`, `" . FORUM_TABLE_PREFIX . "forum`.`id`, `" . FORUM_TABLE_PREFIX . "forum`.`section` FROM `" . FORUM_TABLE_PREFIX . "forum` WHERE `" . FORUM_TABLE_PREFIX . "forum`.`id` = ".(int) $thread['first_post']." LIMIT 1")->fetch();
 		echo '<a href="' . getLink('forum') . '">Boards</a> >> <a href="' . getForumBoardLink($thread['section']) . '">'.$sections[$thread['section']]['name'].'</a> >> <a href="' . getForumThreadLink($thread['first_post']) . '">'.$first_post['post_topic'].'</a> >> <b>Edit post</b>';
-		if(Forum::hasAccess($thread['section'] && ($account_logged->getId() == $thread['author_aid'] || Forum::isModerator())))
+
-		{
+		if(Forum::hasAccess($thread['section'] && ($account_logged->getId() == $thread['author_aid'] || Forum::isModerator()))) {
 			$char_id = $post_topic = $text = $smile = $html = null;
 			$players_from_account = $db->query("SELECT `players`.`name`, `players`.`id` FROM `players` WHERE `players`.`account_id` = ".(int) $account_logged->getId())->fetchAll();
 			$saved = false;
-			if(isset($_REQUEST['save']))
+			if(isset($_REQUEST['save'])) {
-			{
 				$text = stripslashes(trim($_REQUEST['text']));
 				$char_id = (int) $_REQUEST['char_id'];
 				$post_topic = stripslashes(trim($_REQUEST['topic']));
@@ -40,28 +38,35 @@ if(Forum::canPost($account_logged))
 				$html = isset($_REQUEST['html']) ? (int)$_REQUEST['html'] : 0;
 
 				$length = strlen($post_topic);
-				if(($length < 1 || $length > 60) && $thread['id'] == $thread['first_post'])
+				if(($length < 1 || $length > 60) && $thread['id'] == $thread['first_post']) {
 					$errors[] = "Too short or too long topic (Length: $length letters). Minimum 1 letter, maximum 60 letters.";
+				}
 
 				$length = strlen($text);
-				if($length < 1 || $length > 15000)
+				if($length < 1 || $length > 15000) {
 					$errors[] = "Too short or too long post (Length: $length letters). Minimum 1 letter, maximum 15000 letters.";
+				}
 
-				if($char_id == 0)
+				if($char_id == 0) {
 					$errors[] = 'Please select a character.';
+				}
 
-				if(empty($post_topic) && $thread['id'] == $thread['first_post'])
+				if(empty($post_topic) && $thread['id'] == $thread['first_post']) {
 					$errors[] = 'Thread topic can\'t be empty.';
+				}
 
 				$player_on_account = false;
 
-				if(count($errors) == 0)
+				if(count($errors) == 0) {
-				{
+					foreach($players_from_account as $player) {
-					foreach($players_from_account as $player)
+						if ($char_id == $player['id']) {
-						if($char_id == $player['id'])
 							$player_on_account = true;
-					if(!$player_on_account)
+						}
-						$errors[] = 'Player with selected ID '.$char_id.' doesn\'t exist or isn\'t on your account';
+					}
+
+					if(!$player_on_account) {
+						$errors[] = 'Player with selected ID ' . $char_id . ' doesn\'t exist or isn\'t on your account';
+					}
 				}
 
 				if(count($errors) == 0) {
@@ -83,10 +88,10 @@ if(Forum::canPost($account_logged))
 				$html = (int) $thread['post_html'];
 			}
 
-			if(!$saved)
+			if(!$saved) {
-			{
+				if(!empty($errors)) {
-				if(!empty($errors))
 					$twig->display('error_box.html.twig', array('errors' => $errors));
+				}
 
 				$twig->display('forum.edit_post.html.twig', array(
 					'post_id' => $post_id,

system/pages/forum/new_post.php

@@ -12,8 +12,7 @@ defined('MYAAC') or die('Direct access not allowed!');
 
 require __DIR__ . '/base.php';
 
-if(!$logged)
+if(!$logged) {
-{
 	$extra_url = '';
 	if(isset($_GET['thread_id'])) {
 		$extra_url = '&action=new_post&thread_id=' . $_GET['thread_id'];
@@ -23,8 +22,7 @@ if(!$logged)
 	return;
 }
 
-if(Forum::canPost($account_logged))
+if(Forum::canPost($account_logged)) {
-{
 	$players_from_account = $db->query("SELECT `players`.`name`, `players`.`id` FROM `players` WHERE `players`.`account_id` = ".(int) $account_logged->getId())->fetchAll();
 	$thread_id = isset($_REQUEST['thread_id']) ? (int) $_REQUEST['thread_id'] : 0;
 	if($thread_id == 0) {
@@ -35,43 +33,47 @@ if(Forum::canPost($account_logged))
 
 	$thread = $db->query("SELECT `" . FORUM_TABLE_PREFIX . "forum`.`post_topic`, `" . FORUM_TABLE_PREFIX . "forum`.`id`, `" . FORUM_TABLE_PREFIX . "forum`.`section` FROM `" . FORUM_TABLE_PREFIX . "forum` WHERE `" . FORUM_TABLE_PREFIX . "forum`.`id` = ".(int) $thread_id." AND `" . FORUM_TABLE_PREFIX . "forum`.`first_post` = ".$thread_id." LIMIT 1")->fetch();
 
-	if(isset($thread['id']) && Forum::hasAccess($thread['section']))
+	if(isset($thread['id']) && Forum::hasAccess($thread['section'])) {
-	{
 		echo '<a href="' . getLink('forum') . '">Boards</a> >> <a href="' . getForumBoardLink($thread['section']) . '">'.$sections[$thread['section']]['name'].'</a> >> <a href="' . getForumThreadLink($thread_id) . '">'.$thread['post_topic'].'</a> >> <b>Post new reply</b><br /><h3>'.$thread['post_topic'].'</h3>';
 
 		$quote = isset($_REQUEST['quote']) ? (int) $_REQUEST['quote'] : NULL;
 		$text = isset($_REQUEST['text']) ? stripslashes(trim($_REQUEST['text'])) : NULL;
 		$char_id = (int) ($_REQUEST['char_id'] ?? 0);
 		$post_topic = isset($_REQUEST['topic']) ? stripslashes(trim($_REQUEST['topic'])) : '';
-		$smile = (isset($_REQUEST['smile']) ? (int)$_REQUEST['smile'] : 0);
+		$smile = (int)($_REQUEST['smile'] ?? 0);
-		$html = (isset($_REQUEST['html']) ? (int)$_REQUEST['html'] : 0);
+		$html = (int)($_REQUEST['html'] ?? 0);
 		$saved = false;
-		if(isset($_REQUEST['quote']))
-		{
-			$quoted_post = $db->query("SELECT `players`.`name`, `" . FORUM_TABLE_PREFIX . "forum`.`post_text`, `" . FORUM_TABLE_PREFIX . "forum`.`post_date` FROM `players`, `" . FORUM_TABLE_PREFIX . "forum` WHERE `players`.`id` = `" . FORUM_TABLE_PREFIX . "forum`.`author_guid` AND `" . FORUM_TABLE_PREFIX . "forum`.`id` = ".(int) $quote)->fetchAll();
-			if(isset($quoted_post[0]['name']))
-				$text = '[i]Originally posted by '.$quoted_post[0]['name'].' on '.date('d.m.y H:i:s', $quoted_post[0]['post_date']).':[/i][quote]'.$quoted_post[0]['post_text'].'[/quote]';
-		}
-		elseif(isset($_REQUEST['save']))
-		{
-			$length = strlen($text);
-			if($length < 1 || strlen($text) > 15000)
-				$errors[] = 'Too short or too long post (Length: $length letters). Minimum 1 letter, maximum 15000 letters.';
 
-			if($char_id == 0)
+		if(isset($_REQUEST['quote'])) {
+			$quoted_post = $db->query("SELECT `players`.`name`, `" . FORUM_TABLE_PREFIX . "forum`.`post_text`, `" . FORUM_TABLE_PREFIX . "forum`.`post_date` FROM `players`, `" . FORUM_TABLE_PREFIX . "forum` WHERE `players`.`id` = `" . FORUM_TABLE_PREFIX . "forum`.`author_guid` AND `" . FORUM_TABLE_PREFIX . "forum`.`id` = ".(int) $quote)->fetchAll();
+			if(isset($quoted_post[0]['name'])) {
+				$text = '[i]Originally posted by ' . $quoted_post[0]['name'] . ' on ' . date('d.m.y H:i:s', $quoted_post[0]['post_date']) . ':[/i][quote]' . $quoted_post[0]['post_text'] . '[/quote]';
+			}
+		}
+		elseif(isset($_REQUEST['save'])) {
+			$length = strlen($text);
+			if($length < 1 || strlen($text) > 15000) {
+				$errors[] = 'Too short or too long post (Length: $length letters). Minimum 1 letter, maximum 15000 letters.';
+			}
+
+			if($char_id == 0) {
 				$errors[] = 'Please select a character.';
+			}
 
 			$player_on_account = false;
-			if(count($errors) == 0)
+			if(count($errors) == 0) {
-			{
+				foreach($players_from_account as $player) {
-				foreach($players_from_account as $player)
+					if ($char_id == $player['id']) {
-					if($char_id == $player['id'])
 						$player_on_account = true;
-				if(!$player_on_account)
+					}
-					$errors[] = 'Player with selected ID '.$char_id.' doesn\'t exist or isn\'t on your account';
+				}
+
+				if(!$player_on_account) {
+					$errors[] = 'Player with selected ID ' . $char_id . ' doesn\'t exist or isn\'t on your account';
+				}
 			}
-			if(count($errors) == 0)
+
-			{
+			if(count($errors) == 0) {
 				$last_post = 0;
 				$query = $db->query('SELECT post_date FROM ' . FORUM_TABLE_PREFIX . 'forum ORDER BY post_date DESC LIMIT 1');
 				if($query->rowCount() > 0)
@@ -82,10 +84,10 @@ if(Forum::canPost($account_logged))
 				if($last_post+$config['forum_post_interval']-time() > 0 && !Forum::isModerator())
 					$errors[] = 'You can post one time per '.$config['forum_post_interval'].' seconds. Next post after '.($last_post+$config['forum_post_interval']-time()).' second(s).';
 			}
-			if(count($errors) == 0)
+
-			{
+			if(count($errors) == 0) {
 				$saved = true;
-				Forum::add_post($thread['id'], $thread['section'], $account_logged->getId(), (int) $char_id, $text, $post_topic, $smile, $html);
+				Forum::add_post($thread['id'], $thread['section'], $account_logged->getId(), $char_id, $text, $post_topic, $smile, $html);
 				$db->query("UPDATE `" . FORUM_TABLE_PREFIX . "forum` SET `replies`=`replies`+1, `last_post`=".time()." WHERE `id` = ".$thread_id);
 				$post_page = $db->query("SELECT COUNT(`" . FORUM_TABLE_PREFIX . "forum`.`id`) AS posts_count FROM `players`, `" . FORUM_TABLE_PREFIX . "forum` WHERE `players`.`id` = `" . FORUM_TABLE_PREFIX . "forum`.`author_guid` AND `" . FORUM_TABLE_PREFIX . "forum`.`post_date` <= ".time()." AND `" . FORUM_TABLE_PREFIX . "forum`.`first_post` = ".(int) $thread['id'])->fetch();
 				$_page = (int) ceil($post_page['posts_count'] / $config['forum_threads_per_page']) - 1;
@@ -94,12 +96,13 @@ if(Forum::canPost($account_logged))
 			}
 		}
 
-		if(!$saved)
+		if(!$saved) {
-		{
+			if(!empty($errors)) {
-			if(!empty($errors))
 				$twig->display('error_box.html.twig', array('errors' => $errors));
+			}
 
 			$threads = $db->query("SELECT `players`.`name`, `" . FORUM_TABLE_PREFIX . "forum`.`post_text`, `" . FORUM_TABLE_PREFIX . "forum`.`post_topic`, `" . FORUM_TABLE_PREFIX . "forum`.`post_smile`, `" . FORUM_TABLE_PREFIX . "forum`.`post_html`, `" . FORUM_TABLE_PREFIX . "forum`.`author_aid` FROM `players`, `" . FORUM_TABLE_PREFIX . "forum` WHERE `players`.`id` = `" . FORUM_TABLE_PREFIX . "forum`.`author_guid` AND `" . FORUM_TABLE_PREFIX . "forum`.`first_post` = ".(int) $thread_id." ORDER BY `" . FORUM_TABLE_PREFIX . "forum`.`post_date` DESC LIMIT 5")->fetchAll();
+
 			foreach($threads as &$thread) {
 				$player_account = new OTS_Account();
 				$player_account->load($thread['author_aid']);
@@ -128,7 +131,7 @@ if(Forum::canPost($account_logged))
 	}
 }
 else {
-	$errors[] = "Your account is banned, deleted or you don't have any player with level " . $config['forum_level_required'] . " on your account. You can't post.";
+	$errors[] = "Your account is banned, deleted or you don't have any player with level " . config('forum_level_required') . " on your account. You can't post.";
 	displayErrorBoxWithBackButton($errors, getLink('forum'));
 }
 

system/pages/forum/new_thread.php

@@ -12,12 +12,13 @@ defined('MYAAC') or die('Direct access not allowed!');
 
 require __DIR__ . '/base.php';
 
-if(Forum::canPost($account_logged))
+if(Forum::canPost($account_logged)) {
-{
 	$players_from_account = $db->query('SELECT `players`.`name`, `players`.`id` FROM `players` WHERE `players`.`account_id` = '.(int) $account_logged->getId())->fetchAll();
-	$section_id = isset($_REQUEST['section_id']) ? $_REQUEST['section_id'] : null;
+	$section_id = $_REQUEST['section_id'] ?? null;
+
 	if($section_id !== null) {
 		echo '<a href="' . getLink('forum') . '">Boards</a> >> <a href="' . getForumBoardLink($section_id) . '">' . $sections[$section_id]['name'] . '</a> >> <b>Post new thread</b><br />';
+
 		if(isset($sections[$section_id]['name']) && Forum::hasAccess($section_id)) {
 			if ($sections[$section_id]['closed'] && !Forum::isModerator())
 				$errors[] = 'You cannot create topic on this board.';
@@ -33,48 +34,64 @@ if(Forum::canPost($account_logged))
 				$errors = array();
 
 				$length = strlen($post_topic);
-				if ($length < 1 || $length > 60)
+				if ($length < 1 || $length > 60) {
 					$errors[] = "Too short or too long topic (Length: $length letters). Minimum 1 letter, maximum 60 letters.";
+				}
 
 				$length = strlen($text);
-				if ($length < 1 || $length > 15000)
+				if ($length < 1 || $length > 15000) {
 					$errors[] = "Too short or too long post (Length: $length letters). Minimum 1 letter, maximum 15000 letters.";
+				}
 
-				if ($char_id == 0)
+				if ($char_id == 0) {
 					$errors[] = 'Please select a character.';
+				}
+
 				$player_on_account = false;
 
 				if (count($errors) == 0) {
-					foreach ($players_from_account as $player)
+					foreach ($players_from_account as $player) {
-						if ($char_id == $player['id'])
+						if ($char_id == $player['id']) {
 							$player_on_account = true;
-					if (!$player_on_account)
+						}
-						$errors[] = 'Player with selected ID ' . $char_id . ' doesn\'t exist or isn\'t on your account';
+					}
+
+					if (!$player_on_account) {
+						$errors[] = "Player with selected ID $char_id doesn't exist or isn't on your account";
+					}
 				}
 
 				if (count($errors) == 0) {
 					$last_post = 0;
 					$query = $db->query('SELECT `post_date` FROM `' . FORUM_TABLE_PREFIX . 'forum` ORDER BY `post_date` DESC LIMIT 1');
+
 					if ($query->rowCount() > 0) {
 						$query = $query->fetch();
 						$last_post = $query['post_date'];
 					}
-					if ($last_post + $config['forum_post_interval'] - time() > 0 && !Forum::isModerator())
+
-						$errors[] = 'You can post one time per ' . $config['forum_post_interval'] . ' seconds. Next post after ' . ($last_post + $config['forum_post_interval'] - time()) . ' second(s).';
+					if ($last_post + config('forum_post_interval') - time() > 0 && !Forum::isModerator())
+						$errors[] = 'You can post one time per ' . config('forum_post_interval') . ' seconds. Next post after ' . ($last_post + config('forum_post_interval') - time()) . ' second(s).';
 				}
+
 				if (count($errors) == 0) {
 					$saved = true;
-					$db->query("INSERT INTO `" . FORUM_TABLE_PREFIX . "forum` (`first_post` ,`last_post` ,`section` ,`replies` ,`views` ,`author_aid` ,`author_guid` ,`post_text` ,`post_topic` ,`post_smile`, `post_html` ,`post_date` ,`last_edit_aid` ,`edit_date`, `post_ip`) VALUES ('0', '" . time() . "', '" . (int)$section_id . "', '0', '0', '" . $account_logged->getId() . "', '" . (int)$char_id . "', " . $db->quote($text) . ", " . $db->quote($post_topic) . ", '" . (int)$smile . "', '" . (int)$html . "', '" . time() . "', '0', '0', '" . $_SERVER['REMOTE_ADDR'] . "')");
+
+					$db->query("INSERT INTO `" . FORUM_TABLE_PREFIX . "forum` (`first_post` ,`last_post` ,`section` ,`replies` ,`views` ,`author_aid` ,`author_guid` ,`post_text` ,`post_topic` ,`post_smile`, `post_html` ,`post_date` ,`last_edit_aid` ,`edit_date`, `post_ip`) VALUES ('0', '" . time() . "', '" . (int)$section_id . "', '0', '0', '" . $account_logged->getId() . "', '" . $char_id . "', " . $db->quote($text) . ", " . $db->quote($post_topic) . ", '" . $smile . "', '" . $html . "', '" . time() . "', '0', '0', '" . $_SERVER['REMOTE_ADDR'] . "')");
+
 					$thread_id = $db->lastInsertId();
+
 					$db->query("UPDATE `" . FORUM_TABLE_PREFIX . "forum` SET `first_post`=" . (int)$thread_id . " WHERE `id` = " . (int)$thread_id);
 					header('Location: ' . getForumThreadLink($thread_id));
+
 					echo '<br />Thank you for posting.<br /><a href="' . getForumThreadLink($thread_id) . '">GO BACK TO LAST THREAD</a>';
 				}
 			}
 
 			if (!$saved) {
-				if (!empty($errors))
+				if (!empty($errors)) {
 					$twig->display('error_box.html.twig', array('errors' => $errors));
+				}
 
 				$twig->display('forum.new_thread.html.twig', array(
 					'section_id' => $section_id,

system/pages/forum/remove_post.php

@@ -12,19 +12,16 @@ defined('MYAAC') or die('Direct access not allowed!');
 
 require __DIR__ . '/base.php';
 
-if(Forum::isModerator())
+if(Forum::isModerator()) {
-{
 	$id = (int) $_REQUEST['id'];
 	$post = $db->query("SELECT `id`, `first_post`, `section` FROM `" . FORUM_TABLE_PREFIX . "forum` WHERE `id` = ".$id." LIMIT 1")->fetch();
-	if($post['id'] == $id && Forum::hasAccess($post['section']))
+
-	{
+	if($post['id'] == $id && Forum::hasAccess($post['section'])) {
-		if($post['id'] == $post['first_post'])
+		if($post['id'] == $post['first_post']) {
-		{
 			$db->query("DELETE FROM `" . FORUM_TABLE_PREFIX . "forum` WHERE `first_post` = ".$post['id']);
 			header('Location: ' . getForumBoardLink($post['section']));
 		}
-		else
+		else {
-		{
 			$post_page = $db->query("SELECT COUNT(`" . FORUM_TABLE_PREFIX . "forum`.`id`) AS posts_count FROM `players`, `" . FORUM_TABLE_PREFIX . "forum` WHERE `players`.`id` = `" . FORUM_TABLE_PREFIX . "forum`.`author_guid` AND `" . FORUM_TABLE_PREFIX . "forum`.`id` < ".$id." AND `" . FORUM_TABLE_PREFIX . "forum`.`first_post` = ".(int) $post['first_post'])->fetch();
 			$_page = (int) ceil($post_page['posts_count'] / $config['forum_threads_per_page']) - 1;
 			$db->query("DELETE FROM `" . FORUM_TABLE_PREFIX . "forum` WHERE `id` = ".$post['id']);
@@ -38,5 +35,5 @@ if(Forum::isModerator())
 }
 else {
 	$errors[] = 'You are not logged in or you are not moderator.';
-displayErrorBoxWithBackButton($errors, getLink('forum'));
+	displayErrorBoxWithBackButton($errors, getLink('forum'));
 }

system/pages/forum/show_board.php

@@ -16,7 +16,7 @@ $links_to_pages = '';
 $section_id = isset($_REQUEST['id']) ? (int) $_REQUEST['id'] : null;
 
 if($section_id == null || !isset($sections[$section_id])) {
-	$errors[] = "Board with this id does't exist.";
+	$errors[] = "Board with this id doesn't exist.";
 	displayErrorBoxWithBackButton($errors, getLink('forum'));
 	return;
 }
@@ -29,24 +29,24 @@ if(!Forum::hasAccess($section_id)) {
 
 $_page = (int) (isset($_REQUEST['page']) ? $_REQUEST['page'] : 0);
 $threads_count = $db->query("SELECT COUNT(`" . FORUM_TABLE_PREFIX . "forum`.`id`) AS threads_count FROM `players`, `" . FORUM_TABLE_PREFIX . "forum` WHERE `players`.`id` = `" . FORUM_TABLE_PREFIX . "forum`.`author_guid` AND `" . FORUM_TABLE_PREFIX . "forum`.`section` = ".(int) $section_id." AND `" . FORUM_TABLE_PREFIX . "forum`.`first_post` = `" . FORUM_TABLE_PREFIX . "forum`.`id`")->fetch();
-for($i = 0; $i < $threads_count['threads_count'] / $config['forum_threads_per_page']; $i++)
+for($i = 0; $i < $threads_count['threads_count'] / $config['forum_threads_per_page']; $i++) {
-{
 	if($i != $_page)
 		$links_to_pages .= '<a href="' . getForumBoardLink($section_id, $i) . '">'.($i + 1).'</a> ';
 	else
 		$links_to_pages .= '<b>'.($i + 1).' </b>';
 }
+
 echo '<a href="' . getLink('forum') . '">Boards</a> >> <b>'.$sections[$section_id]['name'].'</b>';
-if(!$sections[$section_id]['closed'] || Forum::isModerator())
+
-{
+if(!$sections[$section_id]['closed'] || Forum::isModerator()) {
 	echo '<br /><br />
 		<a href="?subtopic=forum&action=new_thread&section_id='.$section_id.'"><img src="images/forum/topic.gif" border="0" /></a>';
 }
 
 echo '<br /><br />Page: '.$links_to_pages.'<br />';
-$last_threads = $db->query("SELECT `players`.`id` as `player_id`, `players`.`name`, `" . FORUM_TABLE_PREFIX . "forum`.`post_text`, `" . FORUM_TABLE_PREFIX . "forum`.`post_topic`, `" . FORUM_TABLE_PREFIX . "forum`.`id`, `" . FORUM_TABLE_PREFIX . "forum`.`last_post`, `" . FORUM_TABLE_PREFIX . "forum`.`replies`, `" . FORUM_TABLE_PREFIX . "forum`.`views`, `" . FORUM_TABLE_PREFIX . "forum`.`post_date` FROM `players`, `" . FORUM_TABLE_PREFIX . "forum` WHERE `players`.`id` = `" . FORUM_TABLE_PREFIX . "forum`.`author_guid` AND `" . FORUM_TABLE_PREFIX . "forum`.`section` = ".(int) $section_id." AND `" . FORUM_TABLE_PREFIX . "forum`.`first_post` = `" . FORUM_TABLE_PREFIX . "forum`.`id` ORDER BY `" . FORUM_TABLE_PREFIX . "forum`.`last_post` DESC LIMIT ".$config['forum_threads_per_page']." OFFSET ".($_page * $config['forum_threads_per_page']))->fetchAll();
+$last_threads = $db->query("SELECT `players`.`id` as `player_id`, `players`.`name`, `" . FORUM_TABLE_PREFIX . "forum`.`post_text`, `" . FORUM_TABLE_PREFIX . "forum`.`post_topic`, `" . FORUM_TABLE_PREFIX . "forum`.`id`, `" . FORUM_TABLE_PREFIX . "forum`.`last_post`, `" . FORUM_TABLE_PREFIX . "forum`.`replies`, `" . FORUM_TABLE_PREFIX . "forum`.`views`, `" . FORUM_TABLE_PREFIX . "forum`.`post_date` FROM `players`, `" . FORUM_TABLE_PREFIX . "forum` WHERE `players`.`id` = `" . FORUM_TABLE_PREFIX . "forum`.`author_guid` AND `" . FORUM_TABLE_PREFIX . "forum`.`section` = ".$section_id." AND `" . FORUM_TABLE_PREFIX . "forum`.`first_post` = `" . FORUM_TABLE_PREFIX . "forum`.`id` ORDER BY `" . FORUM_TABLE_PREFIX . "forum`.`last_post` DESC LIMIT ".$config['forum_threads_per_page']." OFFSET ".($_page * $config['forum_threads_per_page']))->fetchAll();
-if(isset($last_threads[0]))
+
-{
+if(isset($last_threads[0])) {
 	echo '<table width="100%">
 <tr bgcolor="'.$config['vdarkborder'].'" align="center">
 <td class="white">
@@ -58,8 +58,7 @@ if(isset($last_threads[0]))
 </tr>';
 
 	$player = new OTS_Player();
-	foreach($last_threads as $thread)
+	foreach($last_threads as $thread) {
-	{
 		echo '<tr bgcolor="' . getStyle($number_of_rows++) . '"><td>';
 		if(Forum::isModerator()) {
 			echo '<a href="?subtopic=forum&action=move_thread&id='.$thread['id'].'"\')"><span style="color:darkgreen">[MOVE]</span></a>';
@@ -75,21 +74,24 @@ if(isset($last_threads[0]))
 		$canEditForum = $player_account->hasFlag(FLAG_CONTENT_FORUM) || $player_account->isAdmin();
 
 		echo '<a href="' . getForumThreadLink($thread['id']) . '">'.($canEditForum ? $thread['post_topic'] : htmlspecialchars($thread['post_topic'])) . '</a><br /><small>'.($canEditForum ? substr(strip_tags($thread['post_text']), 0, 50) : htmlspecialchars(substr($thread['post_text'], 0, 50))).'...</small></td><td>' . getPlayerLink($thread['name']) . '</td><td>'.(int) $thread['replies'].'</td><td>'.(int) $thread['views'].'</td><td>';
-		if($thread['last_post'] > 0)
+		if($thread['last_post'] > 0) {
-		{
 			$last_post = $db->query("SELECT `players`.`name`, `" . FORUM_TABLE_PREFIX . "forum`.`post_date` FROM `players`, `" . FORUM_TABLE_PREFIX . "forum` WHERE `" . FORUM_TABLE_PREFIX . "forum`.`first_post` = ".(int) $thread['id']." AND `players`.`id` = `" . FORUM_TABLE_PREFIX . "forum`.`author_guid` ORDER BY `post_date` DESC LIMIT 1")->fetch();
 			if(isset($last_post['name']))
 				echo date('d.m.y H:i:s', $last_post['post_date']).'<br />by ' . getPlayerLink($last_post['name']);
 			else
 				echo 'No posts.';
 		}
-		else
+		else {
-			echo date('d.m.y H:i:s', $thread['post_date']).'<br />by ' . getPlayerLink($thread['name']);
+			echo date('d.m.y H:i:s', $thread['post_date']) . '<br />by ' . getPlayerLink($thread['name']);
+		}
 		echo '</td></tr>';
 	}
+
 	echo '</table>';
-	if(!$sections[$section_id]['closed'] || Forum::isModerator())
+	if(!$sections[$section_id]['closed'] || Forum::isModerator()) {
-		echo '<br /><a href="?subtopic=forum&action=new_thread&section_id='.$section_id.'"><img src="images/forum/topic.gif" border="0" /></a>';
+		echo '<br /><a href="?subtopic=forum&action=new_thread&section_id=' . $section_id . '"><img src="images/forum/topic.gif" border="0" /></a>';
+	}
 }
-else
+else {
 	echo '<h3>No threads in this board.</h3>';
+}

system/pages/forum/show_thread.php

@@ -30,22 +30,22 @@ if(!Forum::hasAccess($thread_starter['section'])) {
 }
 
 $posts_count = $db->query("SELECT COUNT(`" . FORUM_TABLE_PREFIX . "forum`.`id`) AS posts_count FROM `players`, `" . FORUM_TABLE_PREFIX . "forum` WHERE `players`.`id` = `" . FORUM_TABLE_PREFIX . "forum`.`author_guid` AND `" . FORUM_TABLE_PREFIX . "forum`.`first_post` = ".(int) $thread_id)->fetch();
-for($i = 0; $i < $posts_count['posts_count'] / $config['forum_threads_per_page']; $i++)
+for($i = 0; $i < $posts_count['posts_count'] / $config['forum_threads_per_page']; $i++) {
-{
 	if($i != $_page)
 		$links_to_pages .= '<a href="' . getForumThreadLink($thread_id, $i) . '">'.($i + 1).'</a> ';
 	else
 		$links_to_pages .= '<b>'.($i + 1).' </b>';
 }
-$posts = $db->query("SELECT `players`.`id` as `player_id`, `" . FORUM_TABLE_PREFIX . "forum`.`id`,`" . FORUM_TABLE_PREFIX . "forum`.`first_post`, `" . FORUM_TABLE_PREFIX . "forum`.`section`,`" . FORUM_TABLE_PREFIX . "forum`.`post_text`, `" . FORUM_TABLE_PREFIX . "forum`.`post_topic`, `" . FORUM_TABLE_PREFIX . "forum`.`post_date` AS `date`, `" . FORUM_TABLE_PREFIX . "forum`.`post_smile`, `" . FORUM_TABLE_PREFIX . "forum`.`post_html`, `" . FORUM_TABLE_PREFIX . "forum`.`author_aid`, `" . FORUM_TABLE_PREFIX . "forum`.`author_guid`, `" . FORUM_TABLE_PREFIX . "forum`.`last_edit_aid`, `" . FORUM_TABLE_PREFIX . "forum`.`edit_date` FROM `players`, `" . FORUM_TABLE_PREFIX . "forum` WHERE `players`.`id` = `" . FORUM_TABLE_PREFIX . "forum`.`author_guid` AND `" . FORUM_TABLE_PREFIX . "forum`.`first_post` = ".(int) $thread_id." ORDER BY `" . FORUM_TABLE_PREFIX . "forum`.`post_date` LIMIT ".$config['forum_posts_per_page']." OFFSET ".($_page * $config['forum_posts_per_page']))->fetchAll();
+
+$posts = $db->query("SELECT `players`.`id` as `player_id`, `" . FORUM_TABLE_PREFIX . "forum`.`id`,`" . FORUM_TABLE_PREFIX . "forum`.`first_post`, `" . FORUM_TABLE_PREFIX . "forum`.`section`,`" . FORUM_TABLE_PREFIX . "forum`.`post_text`, `" . FORUM_TABLE_PREFIX . "forum`.`post_topic`, `" . FORUM_TABLE_PREFIX . "forum`.`post_date` AS `date`, `" . FORUM_TABLE_PREFIX . "forum`.`post_smile`, `" . FORUM_TABLE_PREFIX . "forum`.`post_html`, `" . FORUM_TABLE_PREFIX . "forum`.`author_aid`, `" . FORUM_TABLE_PREFIX . "forum`.`author_guid`, `" . FORUM_TABLE_PREFIX . "forum`.`last_edit_aid`, `" . FORUM_TABLE_PREFIX . "forum`.`edit_date` FROM `players`, `" . FORUM_TABLE_PREFIX . "forum` WHERE `players`.`id` = `" . FORUM_TABLE_PREFIX . "forum`.`author_guid` AND `" . FORUM_TABLE_PREFIX . "forum`.`first_post` = ".$thread_id." ORDER BY `" . FORUM_TABLE_PREFIX . "forum`.`post_date` LIMIT ".$config['forum_posts_per_page']." OFFSET ".($_page * $config['forum_posts_per_page']))->fetchAll();
+
 if(isset($posts[0]['player_id'])) {
 	$db->query("UPDATE `" . FORUM_TABLE_PREFIX . "forum` SET `views`=`views`+1 WHERE `id` = ".(int) $thread_id);
 }
 
 $lookaddons = $db->hasColumn('players', 'lookaddons');
 $groups = new OTS_Groups_List();
-foreach($posts as &$post)
+foreach($posts as &$post) {
-{
 	$post['player'] = new OTS_Player();
 	$player = $post['player'];
 	$player->load($post['player_id']);