From a1c7c2768cb438edc6bf387faa26450852ed1c84 Mon Sep 17 00:00:00 2001
From: Lee <42119604+Leesneaks@users.noreply.github.com>
Date: Tue, 2 Feb 2021 14:42:30 +0000
Subject: [PATCH] Delete char with house #149

oops, didn't mean to submit that last push, I hadn't added the empty check. (noob moment)
quick fix for #149
---
 system/pages/account/delete_character.php | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/system/pages/account/delete_character.php b/system/pages/account/delete_character.php
index 00a3300b..2c2bb341 100644
--- a/system/pages/account/delete_character.php
+++ b/system/pages/account/delete_character.php
@@ -35,13 +35,6 @@ if(isset($_POST['deletecharactersave']) && $_POST['deletecharactersave'] == 1) {
 		}
 	}
 
-	if($db->hasColumn('houses', 'id')) {
-		$house = $db->query('SELECT `id` FROM `houses` WHERE `owner` = '.$player->getId());
-		if($house->rowCount() > 0) {
-			$errors[] = 'You cannot delete a character when they own a home.';
-		}
-	}
-
 	if(empty($errors) && $password_verify != $account_logged->getPassword()) {
 		$errors[] = 'Wrong password to account.';
 	}
@@ -54,6 +47,13 @@ if(isset($_POST['deletecharactersave']) && $_POST['deletecharactersave'] == 1) {
 		$errors[] = 'This player has been already deleted.';
 	}
 
+	if(empty($errors) && $db->hasColumn('houses', 'id')) {
+		$house = $db->query('SELECT `id` FROM `houses` WHERE `owner` = '.$player->getId());
+		if($house->rowCount() > 0) {
+			$errors[] = 'You cannot delete a character when they own a home.';
+		}
+	}
+
 	if(empty($errors)) {
 		//dont show table "delete character" again
 		$show_form = false;