From 9f3231fff643544be21bc3fdfe80bb18ade2f205 Mon Sep 17 00:00:00 2001 From: slawkens Date: Fri, 16 Feb 2024 20:27:48 +0100 Subject: [PATCH] Fix delete character exception --- system/pages/account/delete_character.php | 16 +++++++++------- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/system/pages/account/delete_character.php b/system/pages/account/delete_character.php index 4e74e711..7804f01d 100644 --- a/system/pages/account/delete_character.php +++ b/system/pages/account/delete_character.php @@ -61,16 +61,18 @@ if(isset($_POST['deletecharactersave']) && $_POST['deletecharactersave'] == 1) { } } - $ownerid = 'ownerid'; - if($db->hasColumn('guilds', 'owner_id')) - $ownerid = 'owner_id'; - $guild = $db->query('SELECT `name` FROM `guilds` WHERE `' . $ownerid . '` = '.$player->getId()); - if($guild->rowCount() > 0) { - $errors[] = 'You cannot delete a character when they own a guild.'; + if(empty($errors)) { + $ownerid = 'ownerid'; + if ($db->hasColumn('guilds', 'owner_id')) + $ownerid = 'owner_id'; + $guild = $db->query('SELECT `name` FROM `guilds` WHERE `' . $ownerid . '` = ' . $player->getId()); + if ($guild->rowCount() > 0) { + $errors[] = 'You cannot delete a character when they own a guild.'; + } } if(empty($errors)) { - //dont show table "delete character" again + // don't show table "delete character" again $show_form = false; /** @var OTS_DB_MySQL $db */ if ($db->hasColumn('players', 'deletion'))