From 9bc63bb55cfda9f4331f862e187910733561f81d Mon Sep 17 00:00:00 2001
From: Lee <42119604+Leesneaks@users.noreply.github.com>
Date: Sat, 7 Nov 2020 13:53:11 +0000
Subject: [PATCH] Datatables update
I noticed if the datatables files wasn't cached some pages that didn't use it would take slightly longer to load whilst it downloaded it.
This will only write the js and css files onto the page if $use_datatable = true; is set on the page.
See accounts/news/players pages for examples.
It wasn't a massive performance loss for the user but not needed if those pages are hardly ever used.
---
admin/template/template.php | 4 ++++
system/pages/admin/accounts.php | 1 +
system/pages/admin/news.php | 1 +
system/pages/admin/players.php | 1 +
4 files changed, 7 insertions(+)
diff --git a/admin/template/template.php b/admin/template/template.php
index ca57f8c6..ebd325ed 100644
--- a/admin/template/template.php
+++ b/admin/template/template.php
@@ -7,7 +7,9 @@
<meta name="viewport" content="width=device-width, initial-scale=1, shrink-to-fit=no">
<link rel="stylesheet" href="<?php echo BASE_URL; ?>tools/css/adminlte.min.css">
<link rel="stylesheet" href="<?php echo BASE_URL; ?>tools/css/font-awesome.min.css">
+ <?php if (isset($use_datatable)) { ?>
<link rel="stylesheet" href="<?php echo BASE_URL; ?>tools/css/datatables.bs.min.css">
+ <?php } ?>
<link rel="stylesheet" type="text/css" href="<?php echo $template_path; ?>style.css"/>
<!--[if lt IE 9]>
<script src="<?php echo BASE_URL; ?>tools/js/html5shiv.min.js"></script>
@@ -173,8 +175,10 @@
?>
<script src="<?php echo BASE_URL; ?>tools/js/bootstrap.min.js"></script>
<script src="<?php echo BASE_URL; ?>tools/js/jquery-ui.min.js"></script>
+<?php if (isset($use_datatable)) { ?>
<script src="<?php echo BASE_URL; ?>tools/js/datatables.min.js"></script>
<script src="<?php echo BASE_URL; ?>tools/js/datatables.bs.min.js"></script>
+<?php } ?>
<script src="<?php echo BASE_URL; ?>tools/js/adminlte.min.js"></script>
</body>
</html>
diff --git a/system/pages/admin/accounts.php b/system/pages/admin/accounts.php
index ded959c9..0660b0d2 100644
--- a/system/pages/admin/accounts.php
+++ b/system/pages/admin/accounts.php
@@ -11,6 +11,7 @@ defined('MYAAC') or die('Direct access not allowed!');
$title = 'Account editor';
$admin_base = BASE_URL . 'admin/?p=accounts';
+$use_datatable = true;
if ($config['account_country'])
require SYSTEM . 'countries.conf.php';
diff --git a/system/pages/admin/news.php b/system/pages/admin/news.php
index 8838780a..46f30c85 100644
--- a/system/pages/admin/news.php
+++ b/system/pages/admin/news.php
@@ -13,6 +13,7 @@ require_once LIBS . 'forum.php';
require_once LIBS . 'news.php';
$title = 'News Panel';
+$use_datatable = true;
if (!hasFlag(FLAG_CONTENT_PAGES) && !superAdmin()) {
echo 'Access denied.';
diff --git a/system/pages/admin/players.php b/system/pages/admin/players.php
index c5f5ca0f..eddc08ca 100644
--- a/system/pages/admin/players.php
+++ b/system/pages/admin/players.php
@@ -12,6 +12,7 @@ defined('MYAAC') or die('Direct access not allowed!');
$title = 'Player editor';
$player_base = BASE_URL . 'admin/?p=players';
+$use_datatable = true;
require_once LIBS . 'forum.php';
$skills = array(