[WIP] More work on settings

Move more config to settings (mainly mail_* + some other)
Remove mail_admin, wasnt used anywhere
Add return type to some functions
Add Twig settings(key) function
Possibility to save setting to db

system/templates/account.create.html.twig

@@ -59,7 +59,7 @@
 													<td></td><td><span id="email_error" class="FormFieldError">{% if errors.email is defined %}{{ errors.email }}{% endif %}</span></td>
 												</tr>
 
-												{% if config.mail_enabled and config.account_mail_verify %}
+												{% if setting('core.mail_enabled') and config.account_mail_verify %}
 													<tr><td></td><td><span><strong>Please use real address!<br/>We will send a link to validate your Email.</strong></span></td></tr>
 												{% endif %}
 
@@ -119,7 +119,7 @@
 
 							{{ hook('HOOK_ACCOUNT_CREATE_BETWEEN_BOXES_1') }}
 
-							{% if (not config.mail_enabled or not config.account_mail_verify) and config.account_create_character_create %}
+							{% if (not setting('core.mail_enabled') or not config.account_mail_verify) and config.account_create_character_create %}
 							<tr>
 								<td>
 									<div class="TableShadowContainerRightTop">

system/templates/experience_table.html.twig

@@ -6,14 +6,14 @@ Remember you can also check the respective skill bar in your skill window of the
 		<td class="white" colspan="5"><b>Experience Table</b></td>
 	</tr>
 	<tr>
-	{% for i in 0..config.experiencetable_columns-1 %}
+	{% for i in 0..setting('core.experience_table_columns')-1 %}
 		<td>
 			<table border="0" cellpadding="2" cellspacing="1" width="100%">
 				<tr bgcolor="{{ config.lightborder }}">
 					<td><b>Level</b></td>
 					<td><b>Experience</b></td>
 				</tr>
-				{% for level in i * config.experiencetable_rows + 1..i * config.experiencetable_rows + (config.experiencetable_rows + 1) - 1 %}
+				{% for level in i * setting('core.experience_table_rows') + 1..i * setting('core.experience_table_rows') + (setting('core.experience_table_rows') + 1) - 1 %}
 				<tr bgcolor="{{ config.lightborder }}">
 					<td>{{ level }}</td>
 					<td>{{ experience[level] }}</td>
@@ -23,4 +23,4 @@ Remember you can also check the respective skill bar in your skill window of the
 		</td>
 	{% endfor %}
 	</tr>
-</table>
+</table>

system/templates/install.config.html.twig

@@ -9,7 +9,7 @@
 <form action="{{ constant('BASE_URL') }}install/" method="post" autocomplete="off">
 	<input type="hidden" name="step" id="step" value="database" />
 
-	{% for value in ['server_path', 'mail_admin'] %}
+	{% for value in ['server_path'] %}
 	<div class="form-group mb-2">
 		<label for="vars_{{ value }}">{{ locale['step_config_' ~ value]  }}</label>
 		<input class="form-control" type="text" name="vars[{{ value }}]" id="vars_{{ value }}"{% if session['var_' ~ value] is not null %} value="{{ session['var_' ~ value] }}"{% endif %}/>
@@ -43,9 +43,9 @@
 		<input type="checkbox" name="vars[usage]" id="vars_usage" value="1"{% if session['var_usage'] is null or session['var_usage'] == 1 %} checked{% endif %}/>
 		<small class="form-text text-muted d-block">{{ locale.step_config_usage_desc }}</small>
 	</div>
-	
+
 	<div class="text-center m-3">
 	{{ buttons|raw }}
 	</div>
 
-</form>
+</form>

system/templates/mail.password_changed.html.twig

@@ -4,4 +4,4 @@ The request was made on {{ "now"|date("F j, Y, g:i a") }} by a user with the IP:
 <br/><br/>
 The new password is: <b>{{ new_password }}</b>
 <br/><br/>
-If this was you, please ignore this email. If it was not you, please contact our support department at {{ config.mail_admin }}.
+If this was you, please ignore this email. If it was not you, please contact our support department.