From 235e0f394dad067176528fd00ca03f1a4fbabfff Mon Sep 17 00:00:00 2001 From: slawkens Date: Fri, 22 Aug 2025 16:04:52 +0200 Subject: [PATCH] Refactor code to use Cache::remember --- system/src/Settings.php | 23 ++++++++--------------- 1 file changed, 8 insertions(+), 15 deletions(-) diff --git a/system/src/Settings.php b/system/src/Settings.php index fe16b2e7..17dc11f4 100644 --- a/system/src/Settings.php +++ b/system/src/Settings.php @@ -25,23 +25,16 @@ class Settings implements \ArrayAccess public function load(): void { - $cache = Cache::getInstance(); - if ($cache->enabled()) { - $tmp = ''; - if ($cache->fetch('settings', $tmp)) { - $this->settingsDatabase = unserialize($tmp); - return; + $this->settingsDatabase = Cache::remember('settings', 10 * 60, function () { + $settingsDatabase = []; + + $settings = ModelsSettings::all(); + foreach ($settings as $setting) { + $settingsDatabase[$setting->name][$setting->key] = $setting->value; } - } - $settings = ModelsSettings::all(); - foreach ($settings as $setting) { - $this->settingsDatabase[$setting->name][$setting->key] = $setting->value; - } - - if ($cache->enabled()) { - $cache->set('settings', serialize($this->settingsDatabase), 600); - } + return $settingsDatabase; + }); } public function save($pluginName, $values): bool