From 9d89836c01aebbb484b68ce3045b165a87e386ab Mon Sep 17 00:00:00 2001 From: Kuzirashi Date: Sat, 19 Apr 2014 23:58:07 +0200 Subject: [PATCH] Fixed errors in Guild Wars. One of them was assigning instead of comparing which, when right side of score was higher than 0, produced only a tie, eg. 1-1, 2-2, 3-3, 4-4. This resolves #47 issue. --- guildwar.php | 29 +++++++++++++++++++++-------- 1 file changed, 21 insertions(+), 8 deletions(-) diff --git a/guildwar.php b/guildwar.php index db8adb5..77aa37a 100644 --- a/guildwar.php +++ b/guildwar.php @@ -32,9 +32,11 @@ if (!empty($_GET['warid'])) { $g2c = 0; // kill count if ($config['TFSVersion'] == 'TFS_02' || $config['TFSVersion'] == 'TFS_10') { - foreach ($kills as $kill) { - if ($kill[killerguild] == $guild1) ++$g1c; - if ($kill[killerguild] == $guild2) ++$g2c; + foreach (($kills ? $kills : array()) as $kill) { + if ($kill['killerguild'] == $guild1) + $g1c++; + else + $g2c++; } $green = false; @@ -55,9 +57,12 @@ if (!empty($_GET['warid'])) {
  • '. $g1c .'-'. $g2c .''; - else if ($g1c = $g2c) echo 'Score: '. $g1c .'-'. $g2c .''; - else echo 'Score: '. $g1c .'-'. $g2c .''; + if ($green) + echo 'Score: '. $g1c .'-'. $g2c .''; + else if ($g1c == $g2c) + echo 'Score: '. $g1c .'-'. $g2c .''; + else + echo 'Score: '. $g1c .'-'. $g2c .''; ?>
  • @@ -73,7 +78,7 @@ if (!empty($_GET['warid'])) { Time: '; //echo ''. get_guild_name($kill['killerguild']) .''; echo ''. get_guild_name($kill['killerguild']) .''; @@ -165,10 +170,18 @@ if (!empty($_GET['warid'])) { '; echo ''. $wars['name1'] .''; - echo ''. count($killsdata[$wars['id']]) .''; + echo ''. $guild_1_kills .' - ' . $guild_2_kills . ''; echo ''. $wars['name2'] .''; echo ''; }