Digitalstack/SabrehavenServer
2
0
Fork 0
mirror of https://github.com/ErikasKontenis/SabrehavenServer.git synced 2025-06-15 13:24:27 +02:00
Code Issues Packages Projects Releases Wiki Activity

Bug Fixes

Browse Source 
Fixed an issue that caused players to increase distance fighting by wielding a distance weapon on hands and on ammunition slots.

Fixed an issue with monster yelling (C code not compatible with C++ entirely, thank you IDA).
This commit is contained in:
Alejandro Mujica 2019-02-05 12:42:16 -04:00
parent 2412e3a825
commit 1aaa6288a8
3 changed files with 17 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
src/combat.cpp
View File

@ -830,7 +830,7 @@ bool Combat::attack(Creature* attacker, Creature* target)
return false; return false;
} }
bool Combat::closeAttack(Creature* attacker, Creature* target, fightMode_t fightMode) bool Combat::closeAttack(Creature* attacker, Creature* target, fightMode_t fightMode, bool fist)
{ {
const Position& attackerPos = attacker->getPosition(); const Position& attackerPos = attacker->getPosition();
const Position& targetPos = target->getPosition(); const Position& targetPos = target->getPosition();
@ -855,7 +855,7 @@ bool Combat::closeAttack(Creature* attacker, Creature* target, fightMode_t fight
uint32_t skillValue = 0; uint32_t skillValue = 0;
uint8_t skill = SKILL_FIST; uint8_t skill = SKILL_FIST;
Combat::getAttackValue(attacker, attackValue, skillValue, skill); Combat::getAttackValue(attacker, attackValue, skillValue, skill, fist);
int32_t defense = target->getDefense(); int32_t defense = target->getDefense();
@ -958,9 +958,9 @@ bool Combat::rangeAttack(Creature* attacker, Creature* target, fightMode_t fight
if (weapon->getWeaponType() == WEAPON_DISTANCE) { if (weapon->getWeaponType() == WEAPON_DISTANCE) {
ammunition = player->getAmmunition(); ammunition = player->getAmmunition();
if (weapon->getAmmoType() != AMMO_NONE) { if (weapon->getAmmoType() != AMMO_NONE) {
if (!ammunition || weapon->getAmmoType() != ammunition->getAmmoType()) { if (!ammunition || ammunition->getWeaponType() != WEAPON_AMMO || weapon->getAmmoType() != ammunition->getAmmoType()) {
// redirect to fist fighting // redirect to fist fighting
return closeAttack(attacker, target, fightMode); return closeAttack(attacker, target, fightMode, true);
} }
distanceEffect = ammunition->getMissileType(); distanceEffect = ammunition->getMissileType();
@ -1007,7 +1007,7 @@ bool Combat::rangeAttack(Creature* attacker, Creature* target, fightMode_t fight
} }
} }
if (ammunition && weapon->getAmmoType() != AMMO_NONE && weapon->getAmmoType() == ammunition->getAmmoType()) { if (ammunition && ammunition->getWeaponType() == WEAPON_AMMO && weapon->getAmmoType() != AMMO_NONE && weapon->getAmmoType() == ammunition->getAmmoType()) {
hitChance = 90; // bows and crossbows hitChance = 90; // bows and crossbows
specialEffect = ammunition->getWeaponSpecialEffect(); specialEffect = ammunition->getWeaponSpecialEffect();
attackStrength = ammunition->getAttackStrength(); attackStrength = ammunition->getAttackStrength();
@ -1178,13 +1178,13 @@ void Combat::circleShapeSpell(Creature* attacker, const Position& toPos, int32_t
} }
} }
void Combat::getAttackValue(Creature* creature, uint32_t& attackValue, uint32_t& skillValue, uint8_t& skill) void Combat::getAttackValue(Creature* creature, uint32_t& attackValue, uint32_t& skillValue, uint8_t& skill, bool fist)
{ {
skill = SKILL_FIST; skill = SKILL_FIST;
if (Player* player = creature->getPlayer()) { if (Player* player = creature->getPlayer()) {
Item* weapon = player->getWeapon(); Item* weapon = player->getWeapon();
if (weapon) { if (weapon && !fist) {
switch (weapon->getWeaponType()) { switch (weapon->getWeaponType()) {
case WEAPON_AXE: { case WEAPON_AXE: {
skill = SKILL_AXE; skill = SKILL_AXE;

4
src/combat.h
View File

@ -285,12 +285,12 @@ class Combat
static int32_t getTotalDamage(int32_t attackSkill, int32_t attackValue, fightMode_t fightMode); static int32_t getTotalDamage(int32_t attackSkill, int32_t attackValue, fightMode_t fightMode);
static bool attack(Creature* attacker, Creature* target); static bool attack(Creature* attacker, Creature* target);
static bool closeAttack(Creature* attacker, Creature* target, fightMode_t fightMode); static bool closeAttack(Creature* attacker, Creature* target, fightMode_t fightMode, bool fist = false);
static bool rangeAttack(Creature* attacker, Creature* target, fightMode_t fightMode); static bool rangeAttack(Creature* attacker, Creature* target, fightMode_t fightMode);
static void circleShapeSpell(Creature* attacker, const Position& toPos, int32_t range, int32_t animation, int32_t radius, DamageImpact* impact, int32_t effect); static void circleShapeSpell(Creature* attacker, const Position& toPos, int32_t range, int32_t animation, int32_t radius, DamageImpact* impact, int32_t effect);
static void getAttackValue(Creature* creature, uint32_t& attackValue, uint32_t& skillValue, uint8_t& skill); static void getAttackValue(Creature* creature, uint32_t& attackValue, uint32_t& skillValue, uint8_t& skill, bool fist = false);
static bool doCombatHealth(Creature* caster, Creature* target, CombatDamage& damage, const CombatParams& params); static bool doCombatHealth(Creature* caster, Creature* target, CombatDamage& damage, const CombatParams& params);
static void doCombatHealth(Creature* caster, const Position& position, const AreaCombat* area, CombatDamage& damage, const CombatParams& params); static void doCombatHealth(Creature* caster, const Position& position, const AreaCombat* area, CombatDamage& damage, const CombatParams& params);

14
src/monster.cpp
View File

@ -1028,13 +1028,15 @@ void Monster::onThinkYell(uint32_t)
int32_t randomResult = rand(); int32_t randomResult = rand();
if (rand() == 50 * (randomResult / 50)) { if (rand() == 50 * (randomResult / 50)) {
int32_t totalVoices = mType->info.voiceVector.size(); if (!mType->info.voiceVector.empty()) {
const voiceBlock_t& voice = mType->info.voiceVector[rand() % totalVoices + 1]; uint32_t index = uniform_random(0, mType->info.voiceVector.size() - 1);
const voiceBlock_t& vb = mType->info.voiceVector[index];
if (voice.yellText) { if (vb.yellText) {
g_game.internalCreatureSay(this, TALKTYPE_MONSTER_YELL, voice.text, false); g_game.internalCreatureSay(this, TALKTYPE_MONSTER_YELL, vb.text, false);
} else { } else {
g_game.internalCreatureSay(this, TALKTYPE_MONSTER_SAY, voice.text, false); g_game.internalCreatureSay(this, TALKTYPE_MONSTER_SAY, vb.text, false);
}
} }
} }
} }